Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ith sync notes Add synchronization notes between create-expert-toml.ts and agents-md-template.ts for the Framework Quality Properties that are defined in both files. Changes: - Rename "Perstack Properties" to "Framework Quality Properties" (consistency) - Remove PS-XXX identifiers (consistency with #379) - Add "Note: Also defined in [other file] - keep synchronized" to both files - Reference docs/making-experts/best-practices.md for public guidelines While full consolidation (extracting to shared module) would require refactoring the template string structure, adding synchronization notes prevents drift and makes the duplication explicit. Closes #385 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
refactor/385-consolidate-duplicates
branch
from
4bedbc9 to
1fa212e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - Error handling: Graceful with helpful messages | ||
|
|
||
| Note: These properties are also defined in create-expert-toml.ts. | ||
| Keep both files synchronized when updating. |
There was a problem hiding this comment.
Internal sync notes leak into generated output
The synchronization notes are placed inside template strings rather than as code comments. In agents-md-template.ts, the note referencing create-expert-toml.ts will appear in every generated AGENTS.md file that users see. In create-expert-toml.ts, the note referencing agents-md-template.ts becomes part of the PROPERTY_EXTRACTOR_INSTRUCTION sent to the LLM. These internal developer notes reference source files that end users and LLMs don't have access to, creating confusing output.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds synchronization notes between create-expert-toml.ts and agents-md-template.ts for the Framework Quality Properties that are defined in both files.
Changes
Renamed "Perstack Properties" to "Framework Quality Properties"
Removed PS-XXX identifiers
Added synchronization notes
Added documentation references
Why Not Full Consolidation
Full consolidation (extracting to a shared module) would require refactoring the template string structure significantly. The synchronization notes approach:
Closes #385
Test plan
Note
Clarifies duplication of Framework Quality Properties and reduces drift risk by adding explicit sync notes.
agents-md-template.tsandcreate-expert-toml.tsnoting the properties are defined in both files and must be kept synchronizedWritten by Cursor Bugbot for commit 1fa212e. This will update automatically on new commits. Configure here.